[libcamera-devel] [PATCH v3 1/2] src: android: Rectify internal header's #include path

Umang Jain umang.jain at ideasonboard.com
Fri Apr 30 06:39:56 CEST 2021


libcamera internal headers are not installed system-wide. Hence, any
inclusion of internal headers should be follow the #include directive
form:
	#include "libcamera/internal/header.h"

This was not the case for a few of the class in android HAL. Fix them.

Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
Reviewed-by: Hirokazu Honda <hiroh at chromium.org>
---
 src/android/camera_stream.h              | 2 +-
 src/android/mm/generic_camera_buffer.cpp | 2 +-
 src/android/post_processor.h             | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h
index f68fdd3a..34016722 100644
--- a/src/android/camera_stream.h
+++ b/src/android/camera_stream.h
@@ -19,7 +19,7 @@
 #include <libcamera/geometry.h>
 #include <libcamera/pixel_format.h>
 
-#include <libcamera/internal/buffer.h>
+#include "libcamera/internal/buffer.h"
 
 class CameraDevice;
 class CameraMetadata;
diff --git a/src/android/mm/generic_camera_buffer.cpp b/src/android/mm/generic_camera_buffer.cpp
index 929e078a..334498c1 100644
--- a/src/android/mm/generic_camera_buffer.cpp
+++ b/src/android/mm/generic_camera_buffer.cpp
@@ -7,7 +7,7 @@
 
 #include "../camera_buffer.h"
 
-#include <libcamera/internal/buffer.h>
+#include "libcamera/internal/buffer.h"
 #include "libcamera/internal/log.h"
 
 using namespace libcamera;
diff --git a/src/android/post_processor.h b/src/android/post_processor.h
index 4944078b..547fda37 100644
--- a/src/android/post_processor.h
+++ b/src/android/post_processor.h
@@ -10,7 +10,7 @@
 #include <libcamera/buffer.h>
 #include <libcamera/stream.h>
 
-#include <libcamera/internal/buffer.h>
+#include "libcamera/internal/buffer.h"
 
 #include "camera_buffer.h"
 
-- 
2.29.2



More information about the libcamera-devel mailing list