[libcamera-devel] [PATCH v4 00/16] Support SensorTimestamp metadata

Jacopo Mondi jacopo at jmondi.org
Fri Apr 30 18:00:10 CEST 2021


A few changes compared to v3

- Reimplement ControlList::merge() not using std::unordered_map::merge()
  This allows the list passed in as parameter to be of const type
- Update the users of ControlList::merge() not to const_cast<>
- Small updates in tests as suggested
- Drop fixes tags and add one to "test: control_list: Check for Brightness
  presence"
- Minor changes to 16/16 as suggested by Hiro: use uint64_t as type for the
  timestamp

Series fully reviewed except for 1/16 and 8/16 and ready to be merged

Thanks
   j

Jacopo Mondi (15):
  test: control_list: Check for Brightness presence
  test: control_list: Test ControlList::merge()
  libcamera: controls: Destage 'SensorTimestamp'
  libcamera: ipu3: Report sensor timestamp
  libcamera: uvc: Report sensor timestamp
  libcamera: rkisp1: Do not over-write metadata
  libcamera: rkisp1: Report sensor timestamp
  libcamera: simple: Report sensor timestamp
  libcamera: vimc: Report sensor timestamp
  libcamera: buffer: Re-work setRequest() documentation
  libcamera: raspberrypi: Do not over-write metadata
  libcamera: raspberry: Report sensor timestamp
  cam: Add option to print the Request metadata
  cam: Implement OptMetadata
  android: camera_device: Use controls::SensorTimestamp

Laurent Pinchart (1):
  libcamera: controls: Add a function to merge two control lists

 include/libcamera/controls.h                  |  2 +
 src/android/camera_device.cpp                 | 21 +++-----
 src/android/camera_device.h                   |  3 +-
 src/cam/capture.cpp                           | 15 +++++-
 src/cam/capture.h                             |  1 +
 src/cam/main.cpp                              |  3 ++
 src/cam/main.h                                |  1 +
 src/libcamera/buffer.cpp                      |  5 +-
 src/libcamera/control_ids.yaml                | 21 +++++---
 src/libcamera/controls.cpp                    | 28 ++++++++++
 src/libcamera/pipeline/ipu3/ipu3.cpp          |  9 ++++
 .../pipeline/raspberrypi/raspberrypi.cpp      | 21 +++++++-
 src/libcamera/pipeline/rkisp1/rkisp1.cpp      | 11 +++-
 src/libcamera/pipeline/simple/simple.cpp      | 12 ++++-
 src/libcamera/pipeline/uvcvideo/uvcvideo.cpp  |  4 ++
 src/libcamera/pipeline/vimc/vimc.cpp          |  4 ++
 test/controls/control_list.cpp                | 51 ++++++++++++++++++-
 17 files changed, 181 insertions(+), 31 deletions(-)

--
2.31.1



More information about the libcamera-devel mailing list