[libcamera-devel] [PATCH v3 2/4] android: Disallow external location in HAL config

[Jacopo Mondi]

Hi Umang,

On Fri, Jul 30, 2021 at 04:31:52PM +0530, Umang Jain wrote:
> Error out on any camera's location if set to "external",
> in the HAL configuration file. The HAL configuration file
> is only meant for the integrated cameras present on the system.
>
> Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>

I think that's fair for the time being

Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

Thanks
   j

> ---
>  src/android/camera_hal_config.cpp | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp
> index 833cf4ba..7126aba4 100644
> --- a/src/android/camera_hal_config.cpp
> +++ b/src/android/camera_hal_config.cpp
> @@ -127,8 +127,6 @@ int CameraHalConfig::Private::parseCameraLocation(CameraConfigData *cameraConfig
>  		cameraConfigData->facing = CAMERA_FACING_FRONT;
>  	else if (location == "back")
>  		cameraConfigData->facing = CAMERA_FACING_BACK;
> -	else if (location == "external")
> -		cameraConfigData->facing = CAMERA_FACING_EXTERNAL;
>  	else
>  		return -EINVAL;
>
> --
> 2.31.0
>