[libcamera-devel] [PATCH] ipu3: Disallow raw only camera configuration

Umang Jain umang.jain at ideasonboard.com
Wed Aug 4 13:26:03 CEST 2021


Ideally to capture the raw frames, ImgU should not be required.
However, we do need to configure the IPA since, it shall setup
the sensor controls (exposure, vblank and so on) for the capture.
One cannot simply configure the IPA, without the ImgU as the
parameters and statistics buffer passed to the IPA are actually
managed by the ImgU.

Until we prepare and setup the ImgU to run an internal queue for
raw-only camera configuration, disallow this configuration and
report it as invalid.

Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>
---
 src/libcamera/pipeline/ipu3/ipu3.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
index 76c3bb3d..3e159279 100644
--- a/src/libcamera/pipeline/ipu3/ipu3.cpp
+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
@@ -248,6 +248,10 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate()
 	if (rawCount > 1 || yuvCount > 2) {
 		LOG(IPU3, Debug) << "Camera configuration not supported";
 		return Invalid;
+	} else if (rawCount && !yuvCount) {
+		LOG(IPU3, Debug)
+			<< "Camera configuration cannot support raw-only streams";
+		return Invalid;
 	}
 
 	/*
-- 
2.31.0



More information about the libcamera-devel mailing list