[libcamera-devel] [PATCH 10/10] libcamera: pipeline: simple: Remove SimplePipelineHandler::activeCamera_

Laurent Pinchart laurent.pinchart at ideasonboard.com
Fri Aug 6 00:24:36 CEST 2021


The SimplePipelineHandler activeCamera_ member pointer is set but never
used. Drop it.

Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 src/libcamera/pipeline/simple/simple.cpp | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
index aa4542ed26b1..7e89e3921dbe 100644
--- a/src/libcamera/pipeline/simple/simple.cpp
+++ b/src/libcamera/pipeline/simple/simple.cpp
@@ -312,8 +312,6 @@ private:
 	std::map<const MediaEntity *, EntityData> entities_;
 
 	MediaDevice *converter_;
-
-	Camera *activeCamera_;
 };
 
 /* -----------------------------------------------------------------------------
@@ -1025,8 +1023,6 @@ int SimplePipelineHandler::start(Camera *camera, [[maybe_unused]] const ControlL
 			video->queueBuffer(buffer.get());
 	}
 
-	activeCamera_ = camera;
-
 	return 0;
 }
 
@@ -1044,7 +1040,6 @@ void SimplePipelineHandler::stop(Camera *camera)
 	video->bufferReady.disconnect(data, &SimpleCameraData::bufferReady);
 
 	data->converterBuffers_.clear();
-	activeCamera_ = nullptr;
 
 	releasePipeline(data);
 }
-- 
Regards,

Laurent Pinchart



More information about the libcamera-devel mailing list