[libcamera-devel] [PATCH 2/2] android: mm: cros_camera_buffer: Fix unused parameter

[Kieran Bingham]

Hi All,

On 05/08/2021 12:03, Laurent Pinchart wrote:
> Hi Umang and Hiro,
> 
> Thank you for the patch.
> 
> On Thu, Aug 05, 2021 at 02:05:51PM +0530, Umang Jain wrote:
>> From: Hirokazu Honda <hiroh at chromium.org>
>>
>> cameraBuffer function in private constructor is unused.
> 
> s/function/parameter/

I just hit this too.

Somehow we need to find a way to incorporate the chromeos build in some
daily/automated builds. :-S

It's just inconvenient because Cros is so big and a somewhat otherwise
moving target ... eek.


>> Mark it as such.
>>
>> Fixes: 33dd4fab9d39("libcamera: base: class: Don't pass Extensible
>> 		     pointer to Private constructor")
> 
> No line wrap for tags.

With that

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> 
>> Signed-off-by: Hirokazu Honda <hiroh at chromium.org>
>> Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>
>> Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> 
>> ---
>>  src/android/mm/cros_camera_buffer.cpp | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/android/mm/cros_camera_buffer.cpp b/src/android/mm/cros_camera_buffer.cpp
>> index 437502fb..e8783ff8 100644
>> --- a/src/android/mm/cros_camera_buffer.cpp
>> +++ b/src/android/mm/cros_camera_buffer.cpp
>> @@ -44,7 +44,7 @@ private:
>>  	} mem;
>>  };
>>  
>> -CameraBuffer::Private::Private(CameraBuffer *cameraBuffer,
>> +CameraBuffer::Private::Private([[maybe_unused]] CameraBuffer *cameraBuffer,
>>  			       buffer_handle_t camera3Buffer,
>>  			       [[maybe_unused]] int flags)
>>  	: handle_(camera3Buffer), numPlanes_(0), valid_(false),
>