[libcamera-devel] [IPU3-IPA PATCH] ipu3: Use ChromeOS tuning file paths

[Kieran Bingham]

On 06/08/2021 13:20, Laurent Pinchart wrote:
> Hi Kieran,
> 
>>>>>> +
>>>>>> +	LOG(IPAIPU3, Info) << "Using tuning file: " << tuningFile;
>>>>>
>>>>> s/://
>>>>
>>>> This would print
>>>>
>>>>  "Using tuning file /etc/camera/ipu3/00imx258.aiqb"
>>>> as opposed to
>>>>  "Using tuning file: /etc/camera/ipu3/00imx258.aiqb"
>>>
>>> That's what I intended, yes :-)
>>>
>>>> The colon is there as a clear demarcation of the separation between
>>>> 'text' and 'filename'....
>>>
>>> Probably a matter of personal preference then ? I think it reads better
>>> with the colon.
>>
>> ... Perhaps - And now I'm confused. I also think it reads better with
>> the colon, that's why I put it there, and why I queried your suggested
>> removal.
>>
>> So I guess I can leave it there if you prefer it ?
> 
> Sorry, I meant without the colon :-) In my head it's like "I've painted
> the bikeshed in red" vs. "I've painted the bikeshed in: red". The latter
> doesn't have the same natural flow. It would be different for "Bikeshed
> colour: red".

Sure - in this instance, if it was a fully qualified sentence - the
colon would be removed.

"Using the tuning file located at /etc/camera/ipu3/" wouldn't need a colon.

But there is a definite shortening of the sentence. I think that's why
the colon makes sense to me to have it there.


> Feel free to keep or drop the colon, as you prefer.

I'll keep it, and move on ;-)

>>>>> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Thanks.

--
Kieran