[libcamera-devel] [PATCH] ipa: raspberrypi: Fix bcm2835-isp inclusion type.

[Laurent Pinchart]

Hi Kieran,

Thank you for the patch.

On Mon, Aug 09, 2021 at 05:57:25PM +0100, Kieran Bingham wrote:
> The bcm2835-isp.h is included with quotes rather than
> angle brackets.
> 
> Quoted includes is reserved for internal includes, while the
> linux/bcm2835-isp.h header is exported from the Linux kernel.
> 
> Fix the inclusion type.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +-
>  src/ipa/raspberrypi/controller/rpi/lux.cpp | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp
> index 1cfdd3bb0f62..289c1fcee289 100644
> --- a/src/ipa/raspberrypi/controller/rpi/agc.cpp
> +++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp
> @@ -7,7 +7,7 @@
>  
>  #include <map>
>  
> -#include "linux/bcm2835-isp.h"
> +#include <linux/bcm2835-isp.h>
>  
>  #include <libcamera/base/log.h>
>  
> diff --git a/src/ipa/raspberrypi/controller/rpi/lux.cpp b/src/ipa/raspberrypi/controller/rpi/lux.cpp
> index 6367b17dc7f4..f77e9140ac10 100644
> --- a/src/ipa/raspberrypi/controller/rpi/lux.cpp
> +++ b/src/ipa/raspberrypi/controller/rpi/lux.cpp
> @@ -6,7 +6,7 @@
>   */
>  #include <math.h>
>  
> -#include "linux/bcm2835-isp.h"
> +#include <linux/bcm2835-isp.h>
>  
>  #include <libcamera/base/log.h>
>  

-- 
Regards,

Laurent Pinchart