[libcamera-devel] [RFC PATCH 0/5] MappedFrameBuffer::maps() returns the plane address

Hirokazu Honda hiroh at chromium.org
Wed Aug 11 14:40:10 CEST 2021


The goal is to acquire the plane address by MappedFrameBuffer::maps().
Currently it returns the address of the begging of a buffer where a
plane exists.

To achieve this, it is necessary to not only change MappedFrameBuffer
implementation, but also fix codes of filling length in
FrameBuffer::Plane. It is set to the buffer length, not plane length,
in some places.

Hirokazu Honda (5):
  libcamera: mapped_framebuffer: Return plane begin address by
    MappedBuffer::maps()
  cam: file_sink: Fix wrong mapping planes
  android: camera_device: Fills the size of plane to
    FrameBuffer::Plane::length
  WIP: libcamera: V4L2VideoDevice: Fix a bug in CreateBuffer()
  WIP: android: jpeg: Use maps() and clean up

 .../libcamera/internal/mapped_framebuffer.h   |  4 +-
 src/android/camera_device.cpp                 | 37 +++++------
 src/android/jpeg/encoder.h                    |  7 ++-
 src/android/jpeg/encoder_libjpeg.cpp          | 32 +++-------
 src/android/jpeg/encoder_libjpeg.h            | 10 +--
 src/android/jpeg/post_processor_jpeg.cpp      | 21 +++++--
 src/android/jpeg/thumbnailer.cpp              | 36 +++++++++--
 src/android/jpeg/thumbnailer.h                |  4 +-
 src/cam/file_sink.cpp                         | 30 +++++++--
 src/cam/file_sink.h                           |  1 +
 src/libcamera/mapped_framebuffer.cpp          | 61 ++++++++++++++++---
 src/libcamera/v4l2_videodevice.cpp            | 15 ++++-
 12 files changed, 178 insertions(+), 80 deletions(-)

--
2.32.0.605.g8dce9f2422-goog


More information about the libcamera-devel mailing list