[libcamera-devel] [PATCH] ipa: ipu3: fix headers order

[Laurent Pinchart]

Hi Jean-Michel,

Thank you for the patch.

On Thu, Aug 12, 2021 at 03:57:50PM +0200, Jean-Michel Hautbois wrote:
> The ipu3 does not follow the current coding style practices for header inclusion.
> Re-order the headers to match the updated styles.

A library-wide patch may be better to be done with this once and for
all. However, before that, ...

> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>
> ---
>  src/ipa/ipu3/ipu3.cpp | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
> index c34fa460..21b9db64 100644
> --- a/src/ipa/ipu3/ipu3.cpp
> +++ b/src/ipa/ipu3/ipu3.cpp
> @@ -22,16 +22,18 @@
>  
>  #include <libcamera/control_ids.h>
>  #include <libcamera/framebuffer.h>
> +#include <libcamera/request.h>
> +
>  #include <libcamera/ipa/ipa_interface.h>
>  #include <libcamera/ipa/ipa_module_info.h>
>  #include <libcamera/ipa/ipu3_ipa_interface.h>
> -#include <libcamera/request.h>

Kieran, is the IPA headers separation something we want to carry
forward, or should we update the clang-format rules ?

>  #include "libcamera/internal/mapped_framebuffer.h"
>  
> +#include "libipa/camera_sensor_helper.h"
> +
>  #include "ipu3_agc.h"
>  #include "ipu3_awb.h"
> -#include "libipa/camera_sensor_helper.h"

The split here doesn't bother me much, but we could also do without it
if desired.

>  static constexpr uint32_t kMaxCellWidthPerSet = 160;
>  static constexpr uint32_t kMaxCellHeightPerSet = 56;

-- 
Regards,

Laurent Pinchart