[libcamera-devel] [PATCH v3 1/9] ipa: move libipa::Algorithm to ipa/ipu3/algorithms

Kieran Bingham kieran.bingham at ideasonboard.com
Wed Aug 18 21:34:47 CEST 2021


On 18/08/2021 20:09, Jean-Michel Hautbois wrote:
> 
> On 18/08/2021 20:52, Laurent Pinchart wrote:
>> On Wed, Aug 18, 2021 at 05:53:55PM +0200, Jean-Michel Hautbois wrote:
>>> The abstract Algorithm class was originally placed in libipa as an attempt to
>>> define a generic algorithm container.
>>> This was a little optimistic and pushed a bit far too early.
>>>
>>> Move the Algorithm class into the IPU3 which is the only user of the class,
>>> as we adapt it to support modular algorithm components for the IPU3.
>>>
>>> Not documenting the namespace may cause issues with Doxygen in libipa.
>>> The file libipa.cpp is thus created as an empty file for now, but we can
>>> leverage it in the future to add more global libipa documentation, and possibly
>>> code too.
>>
>> Please reflow the commit message to 72 columns. Isn't that the default
>> btw, or do I have a local configuration that I have forgotten about ?
> 
> It is the default, but I noticed that when I go inside a line to modify
> it it may not wrap properly, while typing the sentence entirely works
> fine...

Are you using vim ?

If so - when you've updated a paragraph - you can reflow with

<esc> gqip

--
Kieran


More information about the libcamera-devel mailing list