[libcamera-devel] [PATCH v3 6/9] ipa: ipu3: convert AWB to the new algorithm interface

[Kieran Bingham]

On 19/08/2021 12:43, Jean-Michel Hautbois wrote:
> Hi Kieran,
>>> +
>>> +void IPU3Awb::prepare(IPAContext &context, ipu3_uapi_params &params)
>>> +{
>>> +	params.acc_param.awb.config.rgbs_thr_gr = 8191;
>>> +	params.acc_param.awb.config.rgbs_thr_r = 8191;
>>> +	params.acc_param.awb.config.rgbs_thr_gb = 8191;
>>> +	params.acc_param.awb.config.rgbs_thr_b = 8191 | IPU3_UAPI_AWB_RGBS_THR_B_EN | IPU3_UAPI_AWB_RGBS_THR_B_INCL_SAT;
>>> +> +	awbGrid_ = context.configuration.grid.bdsGrid;
>>
>> It looks like we can drop awbGrid_ now and just take a local reference
>> here if you want to shorten lines?
>>
> 
> Well, the grid is used in generateAwbStats() which is called at
> process() call. I could pass it a grid using a reference to the context
> too...

Can those usages get it directly from the IPAContext.configuration?

--
Kieran