[libcamera-devel] [PATCH v1 0/3] Fix Gnome Cheese and multiple camera

[Kieran Bingham]

Hi Nicolas,

On 25/08/2021 22:18, Nicolas Dufresne wrote:
> From: Nicolas Dufresne <nicolas.dufresne at collabora.com>
> 
> This patchset address issues seen when trying to stream from multiple
> cameras at the same time or when using Gnome Cheese software. The core
> of the issue was that multiple CameraManager instances were created.
> Two deadlocks were encountered during testing and are fixed.
> 
> Nicolas Dufresne (3):
>   gstreamer: Fix deadlock when last allocator ref is held by buffer
>   gstreamer: Fix concurrent access issues to CameraManager
>   libcamerasrc: Fix deadlock on EOS

Thank you for these,

Indeed, this also fixes the hangs when shutting down I had experienced
(but not yet reported)

Tested-by: Kieran Bingham <kieran.bingham at ideasonboard.com>


>  src/gstreamer/gstlibcamera-utils.cpp    | 31 +++++++++++++++++++++++++
>  src/gstreamer/gstlibcamera-utils.h      |  6 +++--
>  src/gstreamer/gstlibcameraallocator.cpp | 17 ++++++++------
>  src/gstreamer/gstlibcameraprovider.cpp  | 22 ++----------------
>  src/gstreamer/gstlibcamerasrc.cpp       | 23 +++++++++---------
>  5 files changed, 58 insertions(+), 41 deletions(-)
>