[libcamera-devel] [PATCH 2/2] test: v4l2_compat_test: Fix v4l2-compliance version parsing

[Kieran Bingham]

Hi Paul,

On 27/08/2021 07:25, Paul Elder wrote:
> v4l2-compliance changed their version string:
> 
> v4l2-compliance 1.21.0-4618
> v4l2-compliance SHA: cc211b76476aca2c072ffa83a9b003957d5f3909, 64 bits, 64-bit time_t
> 
> v4l2-compliance 1.21.0-4838, 64 bits, 64-bit time_t
> 
> The current parsing takes the last result of split, which works for the
> former, but not the latter. Take the second result of split instead, and
> strip away any commas.
> 
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> 
> ---
> Kieran, can you please check if this works?


Great, this patch works and does what it needs.

But now I have a failing test :-(

Testing /dev/video2 with vimc driver... failed

Format ioctls (Input 0):
                fail:
../../../utils/v4l2-compliance/v4l2-test-formats.cpp(263):
fmtdesc.description mismatch: was 'Video Format Description', expected
'24-bit RGB 8-8-8'
        test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: FAIL
        test VIDIOC_G/S_PARM: OK (Not Supported)
        test VIDIOC_G_FBUF: OK (Not Supported)
                fail:
../../../utils/v4l2-compliance/v4l2-test-formats.cpp(460): pixelformat
33424752 (RGB3) for buftype 1 not reported by ENUM_FMT
        test VIDIOC_G_FMT: FAIL
                fail:
../../../utils/v4l2-compliance/v4l2-test-formats.cpp(460): pixelformat
33424752 (RGB3) for buftype 1 not reported by ENUM_FMT
        test VIDIOC_TRY_FMT: FAIL
                fail:
../../../utils/v4l2-compliance/v4l2-test-formats.cpp(460): pixelformat
33424752 (RGB3) for buftype 1 not reported by ENUM_FMT
        test VIDIOC_S_FMT: FAIL
        test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
        test Cropping: OK (Not Supported)
        test Composing: OK (Not Supported)
        test Scaling: OK

Total for libcamera device /dev/video2: 54, Succeeded: 50, Failed: 4,
Warnings: 1

Failed 1 tests:
- /dev/video2


I wonder if that's a kernel bug more than a bug from us though ?



> ---
>  test/v4l2_compat/v4l2_compat_test.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/v4l2_compat/v4l2_compat_test.py b/test/v4l2_compat/v4l2_compat_test.py
> index 51bfa952..ae892ced 100755
> --- a/test/v4l2_compat/v4l2_compat_test.py
> +++ b/test/v4l2_compat/v4l2_compat_test.py
> @@ -94,7 +94,7 @@ def main(argv):
>          return TestSkip
>  
>      ret, out = run_with_stdout(v4l2_compliance, '--version')
> -    if ret != 0 or version.parse(out[0].split()[-1]) < MIN_V4L_UTILS_VERSION:
> +    if ret != 0 or version.parse(out[0].split()[1].replace(',', '')) < MIN_V4L_UTILS_VERSION:
>          print('v4l2-compliance version >= 1.21.0 required')
>          return TestSkip
>  
>