[libcamera-devel] [PATCH] clang-format: Remove unsupported option

Kieran Bingham kieran.bingham at ideasonboard.com
Fri Aug 27 14:13:08 CEST 2021


On 27/08/2021 12:38, Laurent Pinchart wrote:
> Hi Kieran,
> 
> Thank you for the patch.
> 
> On Fri, Aug 27, 2021 at 12:01:09PM +0100, Kieran Bingham wrote:
>> The CaseSensitive option requires clang-format 12 which is not widely
>> available.
>>
>> Remove the option, to fix clang-format uses until a solution which
>> supports clang-format version specific configurations can be merged.
> 
> Out of curiosity, have you run into blocking issue when trying to
> implementing this through a symlink, or is that still the plan ?

I have a 'working' implementation. I'm not sure I like it though.

And also, it seemed I still haven't posted it, and given the impending
weekend, I wanted to send this patch so it can be integrated rapidly.

The symlink implementation may take more time to review, which may add
further delay causing discomfort to any users with clang-format < 12.

> 
>> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> 
>> ---
>>  .clang-format | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/.clang-format b/.clang-format
>> index ff60b928affc..5b8857dae924 100644
>> --- a/.clang-format
>> +++ b/.clang-format
>> @@ -77,7 +77,6 @@ IncludeCategories:
>>    # Qt includes (match before C++ standard library)
>>    - Regex:           '<Q([A-Za-z0-9\-_])+>'
>>      Priority:        9
>> -    CaseSensitive:   true
>>    # Headers in <> with an extension. (+system libraries)
>>    - Regex:           '<([A-Za-z0-9\-_])+\.h>'
>>      Priority:        2
> 


More information about the libcamera-devel mailing list