[libcamera-devel] [PATCH 2/2] libcamera: Add OV2680 sensor properties

[Laurent Pinchart]

Hi Dan,

Thank you for the patch.

On Tue, Nov 30, 2021 at 09:34:11PM +0000, Daniel Scally wrote:
> Add camera sensor properties for the OV2680 sensor - this is the
> user facing camera on the Lenovo Miix 510.
> 
> Signed-off-by: Daniel Scally <djrscally at gmail.com>
> ---
>  src/libcamera/camera_sensor_properties.cpp | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp
> index 48305ac4..a97552ce 100644
> --- a/src/libcamera/camera_sensor_properties.cpp
> +++ b/src/libcamera/camera_sensor_properties.cpp
> @@ -90,6 +90,19 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
>  				{ controls::draft::TestPatternModePn9, 4 },
>  			},
>  		} },
> +		{ "ov2680", {
> +			.unitCellSize = { 1750, 1750 },
> +			.testPatternModes = {
> +				{ controls::draft::TestPatternModeOff, 0 },
> +				{ controls::draft::TestPatternModeColorBars, 1 },

Does this match the colour bars test pattern defined by the CCS
specification, as described by the test pattern control documentation ?
If not, I wouldn't enable it for now (we don't have support for custom
patterns yet).

> +				/*
> +				 * No corresponding test pattern mode for:
> +				 * 2. "Random Data"
> +				 * 3. "Square"
> +				 * 4. "Black Image
> +				 */
> +			},
> +		} },
>  		{ "ov5647", {
>  			.unitCellSize = { 1400, 1400 },
>  			.testPatternModes = {},

-- 
Regards,

Laurent Pinchart