[libcamera-devel] [PATCH v5 09/12] android: camera_stream: Add thread safety annotation
Hirokazu Honda
hiroh at chromium.org
Wed Dec 1 08:53:45 CET 2021
This applies clang thread safety annotation to CameraStream.
Signed-off-by: Hirokazu Honda <hiroh at chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>
---
src/android/camera_stream.cpp | 2 +-
src/android/camera_stream.h | 8 +++++---
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp
index 2181d094..ae659808 100644
--- a/src/android/camera_stream.cpp
+++ b/src/android/camera_stream.cpp
@@ -275,7 +275,7 @@ void CameraStream::PostProcessorWorker::run()
MutexLocker locker(mutex_);
while (1) {
- cv_.wait(locker, [&] {
+ cv_.wait(locker, [&]() LIBCAMERA_TSA_REQUIRES(mutex_) {
return state_ != State::Running || !requests_.empty();
});
diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h
index e4eb953a..7b1a2980 100644
--- a/src/android/camera_stream.h
+++ b/src/android/camera_stream.h
@@ -155,8 +155,10 @@ private:
libcamera::Mutex mutex_;
libcamera::ConditionVariable cv_;
- std::queue<Camera3RequestDescriptor::StreamBuffer *> requests_;
- State state_ = State::Stopped;
+ std::queue<Camera3RequestDescriptor::StreamBuffer *> requests_
+ LIBCAMERA_TSA_GUARDED_BY(mutex_);
+
+ State state_ LIBCAMERA_TSA_GUARDED_BY(mutex_) = State::Stopped;
};
int waitFence(int fence);
@@ -168,7 +170,7 @@ private:
const unsigned int index_;
std::unique_ptr<libcamera::FrameBufferAllocator> allocator_;
- std::vector<libcamera::FrameBuffer *> buffers_;
+ std::vector<libcamera::FrameBuffer *> buffers_ LIBCAMERA_TSA_GUARDED_BY(mutex_);
/*
* The class has to be MoveConstructible as instances are stored in
* an std::vector in CameraDevice.
--
2.34.0.rc2.393.gf8c9666880-goog
More information about the libcamera-devel
mailing list