[libcamera-devel] [PATCH v5 12/12] android: camera_request: Add thread safety annotation

Umang Jain umang.jain at ideasonboard.com
Wed Dec 1 11:36:22 CET 2021


Hi Hiro,


On 12/1/21 1:23 PM, Hirokazu Honda wrote:
> This applies clang thread safety annotation to
> Camera3RequestDescriptor.
>
> Signed-off-by: Hirokazu Honda <hiroh at chromium.org>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>


Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>

> ---
>   src/android/camera_request.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/android/camera_request.h b/src/android/camera_request.h
> index 887dbe86..d9b04f16 100644
> --- a/src/android/camera_request.h
> +++ b/src/android/camera_request.h
> @@ -57,7 +57,8 @@ public:
>   	};
>   
>   	/* Keeps track of streams requiring post-processing. */
> -	std::map<CameraStream *, StreamBuffer *> pendingStreamsToProcess_;
> +	std::map<CameraStream *, StreamBuffer *> pendingStreamsToProcess_
> +		LIBCAMERA_TSA_GUARDED_BY(streamsProcessMutex_);
>   	libcamera::Mutex streamsProcessMutex_;
>   
>   	Camera3RequestDescriptor(libcamera::Camera *camera,


More information about the libcamera-devel mailing list