[libcamera-devel] [PATCH v2 7/7] ipa: ipu3: Send lens controls to pipeline handler

[Laurent Pinchart]

Hi Daniel,

Thank you for the patch.

On Fri, Dec 03, 2021 at 10:42:30PM +0000, Daniel Scally wrote:
> Pick up the focus value from the AF algorithm and send lens controls
> along in the frame context.
> 
> Signed-off-by: Daniel Scally <djrscally at gmail.com>
> ---
> Changes in v2:
> 
> 	- Created a ControlList to hold the lensCtrls (Laurent)
> 
>  src/ipa/ipu3/ipu3.cpp | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
> index 3828650d..5c57797d 100644
> --- a/src/ipa/ipu3/ipu3.cpp
> +++ b/src/ipa/ipu3/ipu3.cpp
> @@ -174,6 +174,7 @@ private:
>  	uint32_t gain_;
>  	uint32_t minGain_;
>  	uint32_t maxGain_;
> +	uint32_t focus_;

I don't think you need to store focus_ here, as it's only used locally
in setControls().

>  
>  	utils::Duration lineDuration_;
>  
> @@ -674,6 +675,12 @@ void IPAIPU3::setControls(unsigned int frame)
>  	ctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast<int32_t>(gain_));
>  	op.sensorControls = ctrls;
>  
> +	focus_ = context_.frameContext.af.focus;
> +
> +	ControlList lensCtrls(lensCtrls_);
> +	lensCtrls.set(V4L2_CID_FOCUS_ABSOLUTE, static_cast<int32_t>(focus_));
> +	op.lensControls = lensCtrls;
> +
>  	queueFrameAction.emit(frame, op);
>  }
>  

-- 
Regards,

Laurent Pinchart