[libcamera-devel] [PATCH 7/8] gstreamer: gstlibcamerasrc: Fix include ordering

Umang Jain umang.jain at ideasonboard.com
Tue Dec 7 14:58:44 CET 2021


Hi

On 12/7/21 5:09 AM, Kieran Bingham wrote:
> The libcamera coding style has libcamera headers after system headers,
> and before any other library headers.
>
> Move the libcamera headers above the Gst headers accordingly.
>
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>


Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>

> ---
>   src/gstreamer/gstlibcamerasrc.cpp | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp
> index 812ba7a2bd6e..c7292f66b17b 100644
> --- a/src/gstreamer/gstlibcamerasrc.cpp
> +++ b/src/gstreamer/gstlibcamerasrc.cpp
> @@ -32,11 +32,11 @@
>   #include <queue>
>   #include <vector>
>   
> -#include <gst/base/base.h>
> -
>   #include <libcamera/camera.h>
>   #include <libcamera/camera_manager.h>
>   
> +#include <gst/base/base.h>
> +
>   #include "gstlibcameraallocator.h"
>   #include "gstlibcamerapad.h"
>   #include "gstlibcamerapool.h"


More information about the libcamera-devel mailing list