[libcamera-devel] [PATCH 1/8] libcamera: controls: Add SensorSequence metadata control

[Naushir Patuck]

Hi Kieran,

Thank you for your patch.

On Mon, 6 Dec 2021 at 23:39, Kieran Bingham <kieran.bingham at ideasonboard.com>
wrote:

> Provide a metadata control that allows pipeline handlers to report the
> sequence number from the sensor for every request.
>
> This can be used to monitor and validate the sequence numbers of the
> captured images and detect any frame drops.
>
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
>  src/libcamera/control_ids.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/src/libcamera/control_ids.yaml
> b/src/libcamera/control_ids.yaml
> index 9d4638ae677e..8874fe75102c 100644
> --- a/src/libcamera/control_ids.yaml
> +++ b/src/libcamera/control_ids.yaml
> @@ -381,6 +381,14 @@ controls:
>          \todo Define how the sensor timestamp has to be used in the
> reprocessing
>          use case.
>
> +  - SensorSequence:
> +      type: int64_t
> +      description: |
> +        The monotonic sequence number from the sensor.
> +
> +        Any break in the sequence number is an indication of frame drop
> or error
> +        in the captured stream.
> +
>

Should we add that there are no guarantees about this sequence number being
reset on start/stop?

Reviewed-by: Naushir Patuck <naush at raspberrypi.com>



>    #
> ----------------------------------------------------------------------------
>    # Draft controls section
>
> --
> 2.30.2
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20211207/2315e536/attachment.htm>