[libcamera-devel] [RFC v3 1/5] HACK: Camera public destructor
Tomi Valkeinen
tomi.valkeinen at ideasonboard.com
Thu Dec 9 10:29:02 CET 2021
pybind11 needs a public destructor for Camera to be able to manage the
shared_ptr. It's not clear why this is needed, and can it be fixed in
pybind11.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>
---
include/libcamera/camera.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h
index a7759ccb..88a61ff5 100644
--- a/include/libcamera/camera.h
+++ b/include/libcamera/camera.h
@@ -104,12 +104,12 @@ public:
int start(const ControlList *controls = nullptr);
int stop();
+ ~Camera();
private:
LIBCAMERA_DISABLE_COPY(Camera)
Camera(std::unique_ptr<Private> d, const std::string &id,
const std::set<Stream *> &streams);
- ~Camera();
friend class PipelineHandler;
void disconnect();
--
2.25.1
More information about the libcamera-devel
mailing list