[libcamera-devel] [PATCH 1/2] test: fence: Check write return value
Jacopo Mondi
jacopo at jmondi.org
Mon Dec 13 15:51:42 CET 2021
The ::write() function used to signal a framebuffer fence in the unit
test is marked with the 'warn_unused_result'.
When building in debugoptimized mode not checking for the return
value causes issues at build time:
/test/fence.cpp:254:2: error: ignoring return value of function declared with 'warn_unused_result' attribute
Fix that by checking the ::write() return value and emitting an
error message in case the write fails.
Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
---
test/fence.cpp | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/test/fence.cpp b/test/fence.cpp
index d2dfc9b615a9..d2865398784e 100644
--- a/test/fence.cpp
+++ b/test/fence.cpp
@@ -251,7 +251,12 @@ void FenceTest::requestComplete(Request *request)
void FenceTest::signalFence()
{
uint64_t value = 1;
- write(efd2_, &value, sizeof(value));
+ int ret;
+
+ ret = write(efd2_, &value, sizeof(value));
+ if (ret != sizeof(value))
+ cerr << "Failed to signal fence" << endl;
+
dispatcher_->processEvents();
}
--
2.33.1
More information about the libcamera-devel
mailing list