[libcamera-devel] [PATCH v2 5/6] android: Increase result metadata size

[Jacopo Mondi]

Hi Paul

On Mon, Dec 20, 2021 at 05:26:28PM -0600, Paul Elder wrote:
> Increase the initial size of the result metadata, as we will be adding
> more entries in the near future.
>
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
>  src/android/camera_device.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
> index f28fdd6a..83825736 100644
> --- a/src/android/camera_device.cpp
> +++ b/src/android/camera_device.cpp
> @@ -1313,7 +1313,7 @@ CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor) cons
>  	 * Total bytes for JPEG metadata: 82
>  	 */
>  	std::unique_ptr<CameraMetadata> resultMetadata =
> -		std::make_unique<CameraMetadata>(44, 166);
> +		std::make_unique<CameraMetadata>(88, 166);

I wonder if the size should be bumped too. But it seems you only get
complaints about the number of entries ?

Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

Thanks
   j

>  	if (!resultMetadata->isValid()) {
>  		LOG(HAL, Error) << "Failed to allocate result metadata";
>  		return nullptr;
> --
> 2.27.0
>