[libcamera-devel] [PATCH 1/2] utils: gen-formats: Support big-endian DRM formats

[Niklas Söderlund]

Hi Laurent,

Thanks for your work.

On 2021-01-31 20:43:51 +0200, Laurent Pinchart wrote:
> DRM 4CCs are defined in little-endian, and can be declined in a
> big-endian version by setting bit 31 (DRM_FORMAT_BIG_ENDIAN) in the 4CC
> value.
> 
> Add support for such formats in the gen-formats.py script.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

> ---
>  utils/gen-formats.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/utils/gen-formats.py b/utils/gen-formats.py
> index 60dcecc345d5..da79a8bbba3a 100755
> --- a/utils/gen-formats.py
> +++ b/utils/gen-formats.py
> @@ -59,10 +59,13 @@ def generate_h(formats, drm_fourcc):
>  
>      for format in formats:
>          name, format = format.popitem()
> +        fourcc = drm_fourcc.fourcc(format['fourcc'])
> +        if format.get('big-endian'):
> +            fourcc += '| DRM_FORMAT_BIG_ENDIAN'
>  
>          data = {
>              'name': name,
> -            'fourcc': drm_fourcc.fourcc(format['fourcc']),
> +            'fourcc': fourcc,
>              'mod': '0, 0',
>          }
>  
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

-- 
Regards,
Niklas Söderlund