[libcamera-devel] [PATCH] test: buffer-import: Fix false-positive failure
Kieran Bingham
kieran.bingham at ideasonboard.com
Tue Feb 2 18:34:05 CET 2021
Running the tests failed with the following error on buffer import:
"Failed to capture enough frames (got 8 expected at least 8)"
This indicates that the test did in fact capture enough frames as
desired by the test. Update the comparison on both buffer-import and
capture tests accordingly.
Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
---
test/camera/buffer_import.cpp | 2 +-
test/camera/capture.cpp | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp
index 7ff628269c47..61f4eb92ae95 100644
--- a/test/camera/buffer_import.cpp
+++ b/test/camera/buffer_import.cpp
@@ -138,7 +138,7 @@ protected:
while (timer.isRunning())
dispatcher->processEvents();
- if (completeRequestsCount_ <= cfg.bufferCount * 2) {
+ if (completeRequestsCount_ < cfg.bufferCount * 2) {
std::cout << "Failed to capture enough frames (got "
<< completeRequestsCount_ << " expected at least "
<< cfg.bufferCount * 2 << ")" << std::endl;
diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp
index 6d564fe453ac..c4bc21100777 100644
--- a/test/camera/capture.cpp
+++ b/test/camera/capture.cpp
@@ -142,7 +142,7 @@ protected:
unsigned int nbuffers = allocator_->buffers(stream).size();
- if (completeRequestsCount_ <= nbuffers * 2) {
+ if (completeRequestsCount_ < nbuffers * 2) {
cout << "Failed to capture enough frames (got "
<< completeRequestsCount_ << " expected at least "
<< nbuffers * 2 << ")" << endl;
--
2.25.1
More information about the libcamera-devel
mailing list