[libcamera-devel] [PATCH] libcamera: ipu3: cio2: Fix line break

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Feb 2 22:26:26 CET 2021


Hi Jacopo,

Thank you for the patch.

On Tue, Feb 02, 2021 at 03:51:14PM +0100, Jacopo Mondi wrote:
> The function declaration fits on one line.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> ---
>  src/libcamera/pipeline/ipu3/cio2.cpp | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp
> index bd5260d5b288..72e88067f55f 100644
> --- a/src/libcamera/pipeline/ipu3/cio2.cpp
> +++ b/src/libcamera/pipeline/ipu3/cio2.cpp
> @@ -195,8 +195,7 @@ int CIO2Device::configure(const Size &size, V4L2DeviceFormat *outputFormat)
>  	return 0;
>  }
>  
> -StreamConfiguration
> -CIO2Device::generateConfiguration(Size size) const
> +StreamConfiguration CIO2Device::generateConfiguration(Size size) const

Hmmmm... That's a complex change, I'm not sure I have the knowledge
necessary to review this, but I'll still give it a go :-)

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

>  {
>  	StreamConfiguration cfg;
>  

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list