[libcamera-devel] [PATCH 3/7] ipa: raspberrypi: ccm: Remove unnecessary atomic variable

Laurent Pinchart laurent.pinchart at ideasonboard.com
Sun Feb 7 15:05:39 CET 2021


Hi David,

Thank you for the patch.

On Thu, Feb 04, 2021 at 09:34:53AM +0000, David Plowman wrote:
> SetSaturation() gets called synchronously so there is no need for
> saturation_ to be atomic.
> 
> Signed-off-by: David Plowman <david.plowman at raspberrypi.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/ipa/raspberrypi/controller/rpi/ccm.hpp | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/ipa/raspberrypi/controller/rpi/ccm.hpp b/src/ipa/raspberrypi/controller/rpi/ccm.hpp
> index fcf077e7..330ed51f 100644
> --- a/src/ipa/raspberrypi/controller/rpi/ccm.hpp
> +++ b/src/ipa/raspberrypi/controller/rpi/ccm.hpp
> @@ -7,7 +7,6 @@
>  #pragma once
>  
>  #include <vector>
> -#include <atomic>
>  
>  #include "../ccm_algorithm.hpp"
>  #include "../pwl.hpp"
> @@ -70,7 +69,7 @@ public:
>  
>  private:
>  	CcmConfig config_;
> -	std::atomic<double> saturation_;
> +	double saturation_;
>  };
>  
>  } // namespace RPiController

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list