[libcamera-devel] [PATCH 5/7] ipa: raspberrypi: noise: Remove unnecessary atomic variable

[Laurent Pinchart]

Hi David,

Thank you for the patch.

On Thu, Feb 04, 2021 at 09:34:55AM +0000, David Plowman wrote:
> mode_factor_ does not need to be atomic - it is set by SwitchMode()
> which runs synchronously.
> 
> Signed-off-by: David Plowman <david.plowman at raspberrypi.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/ipa/raspberrypi/controller/rpi/noise.hpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/raspberrypi/controller/rpi/noise.hpp b/src/ipa/raspberrypi/controller/rpi/noise.hpp
> index 6f6e0be9..1c9de5c8 100644
> --- a/src/ipa/raspberrypi/controller/rpi/noise.hpp
> +++ b/src/ipa/raspberrypi/controller/rpi/noise.hpp
> @@ -26,7 +26,7 @@ private:
>  	// the noise profile for analogue gain of 1.0
>  	double reference_constant_;
>  	double reference_slope_;
> -	std::atomic<double> mode_factor_;
> +	double mode_factor_;
>  };
>  
>  } // namespace RPiController

-- 
Regards,

Laurent Pinchart