[libcamera-devel] [PATCH 2/2] ipa: raspberrypi: Remove libatomic from build dependencies

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon Feb 8 17:17:35 CET 2021


Hi David,

Thank you for the patch.

On Mon, Feb 08, 2021 at 09:40:36AM +0000, David Plowman wrote:
> With all the atomic variables removed from the Raspberry Pi control
> algorithms, libatomic is no longer required.
> 
> Signed-off-by: David Plowman <david.plowman at raspberrypi.com>
> ---
>  src/ipa/raspberrypi/meson.build | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/ipa/raspberrypi/meson.build b/src/ipa/raspberrypi/meson.build
> index 9445cd09..4cdd0434 100644
> --- a/src/ipa/raspberrypi/meson.build
> +++ b/src/ipa/raspberrypi/meson.build
> @@ -5,7 +5,6 @@ ipa_name = 'ipa_rpi'
>  rpi_ipa_deps = [
>      libcamera_dep,
>      dependency('boost'),
> -    libatomic,

As mentioned in the previous version, I'm a bit cautious about this
change, because I don't fully understand the need to link to libatomic
on some platforms. I believe it should be safe, so I'm willing to give
it a try.

Kieran, I think the issue was initially reported by builroot, when
compiling on sparc. Do we have an easy way to test this ?

>  ]
>  
>  rpi_ipa_includes = [

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list