[libcamera-devel] [PATCH v6 0/6] Raspberry Pi: Colour denoise

[Laurent Pinchart]

Hi Naush,

On Mon, Feb 08, 2021 at 03:07:32PM +0000, Naushir Patuck wrote:
> Hi all,
> 
> Here is the next revision of the colour denoise work.
> 
> This version includes all of the small typos pointed out in the last round of reviews.
> I've also added a \todo for the following items:
> 1) Disable ISP output 1 if we know colour denoise will not be running due to a resolution/format mismatch.
> 2) Return out the correct metadata status for CDN if it is not running.

There's a typo in patch 2/6, and I think there's also a bug in 4/6 that
was likely cause by a rebase problem. I can fix these when applying if
my analysis is correct.

> Naushir Patuck (6):
>   pipeline: raspberrypi: Refactor stream configuration routine
>   pipeline: raspberrypi: Set the ISP Output1 to 1/4 resolution if unused
>   uapi: raspberrypi: Update the bcm2835-isp header definition
>   ipa: raspberrypi: Rename SdnStatus to DenoiseStatus
>   ipa: raspberrypi: Add a DenoiseAlgorithm class to the Controller
>   ipa: raspberrypi: Handle control::NoiseReductionMode in the controller
> 
>  include/libcamera/ipa/raspberrypi.h           |  1 +
>  include/linux/bcm2835-isp.h                   | 32 +++++-
>  .../controller/denoise_algorithm.hpp          | 23 +++++
>  .../raspberrypi/controller/denoise_status.h   | 24 +++++
>  src/ipa/raspberrypi/controller/rpi/sdn.cpp    | 15 ++-
>  src/ipa/raspberrypi/controller/rpi/sdn.hpp    |  5 +-
>  src/ipa/raspberrypi/controller/sdn_status.h   | 23 -----
>  src/ipa/raspberrypi/raspberrypi.cpp           | 65 ++++++++++++-
>  .../pipeline/raspberrypi/raspberrypi.cpp      | 97 +++++++++++--------
>  9 files changed, 210 insertions(+), 75 deletions(-)
>  create mode 100644 src/ipa/raspberrypi/controller/denoise_algorithm.hpp
>  create mode 100644 src/ipa/raspberrypi/controller/denoise_status.h
>  delete mode 100644 src/ipa/raspberrypi/controller/sdn_status.h

-- 
Regards,

Laurent Pinchart