[libcamera-devel] [PATCH v2 6/6] libcamera: MappedBuffer: Disable copy and assignment

Kieran Bingham kieran.bingham at ideasonboard.com
Thu Feb 11 14:34:44 CET 2021


Prevent copying and assignment of MappedBuffer types, which could invoke
undesired unmapping of mapped memory.

Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
---
 include/libcamera/internal/buffer.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/libcamera/internal/buffer.h b/include/libcamera/internal/buffer.h
index b7b0173f93f5..b980deaf58d5 100644
--- a/include/libcamera/internal/buffer.h
+++ b/include/libcamera/internal/buffer.h
@@ -10,6 +10,7 @@
 #include <sys/mman.h>
 #include <vector>
 
+#include <libcamera/class.h>
 #include <libcamera/buffer.h>
 #include <libcamera/span.h>
 
@@ -34,6 +35,9 @@ protected:
 
 	int error_;
 	std::vector<Plane> maps_;
+
+private:
+	LIBCAMERA_DISABLE_COPY(MappedBuffer);
 };
 
 class MappedFrameBuffer : public MappedBuffer
-- 
2.25.1



More information about the libcamera-devel mailing list