[libcamera-devel] [PATCH 2/2] libcamera: Drop unneeded depend_files from meson custom targets

Kieran Bingham kieran.bingham at ideasonboard.com
Thu Feb 11 17:15:15 CET 2021


On 11/02/2021 16:02, Laurent Pinchart wrote:
> Hi Kieran,
>> Seems to make sense. This makes me remember the race conditions we've
>> had in the past, but I can't see that this makes a difference here, so I
>> think it's good as long at the dependency is met.
> 
> If it helps you sleep better, I've checked both the meson implementation
> and the generated ninja files to make sure the dependency is correctly
> handled through the command argument, and it seems to be the case.

ZZzzzzzz ;-D

> 
>> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>>
>>> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>


More information about the libcamera-devel mailing list