[libcamera-devel] [PATCH] ipa: raspberrypi: Fix exposure and gain delays for imx477

[David Plowman]

Hi Naush

Thanks for correcting this!

Reviewed-by: David Plowman <david.plowman at raspberrypi.com>
Tested-by: David Plowman <david.plowman at raspberrypi.com>

Best regards
David

On Tue, 16 Feb 2021 at 08:55, Naushir Patuck <naush at raspberrypi.com> wrote:
>
> The exposure and gain delays for imx477 are both 2 frames. This error
> was not noticeable because the controller was using the embedded
> metadata to get the exposure and gain values for the frame.
>
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> ---
>  src/ipa/raspberrypi/cam_helper_imx477.cpp | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/src/ipa/raspberrypi/cam_helper_imx477.cpp b/src/ipa/raspberrypi/cam_helper_imx477.cpp
> index 9a53c5dba9f8..e26c91f7d86d 100644
> --- a/src/ipa/raspberrypi/cam_helper_imx477.cpp
> +++ b/src/ipa/raspberrypi/cam_helper_imx477.cpp
> @@ -37,6 +37,7 @@ public:
>         CamHelperImx477();
>         uint32_t GainCode(double gain) const override;
>         double Gain(uint32_t gain_code) const override;
> +       void GetDelays(int &exposure_delay, int &gain_delay) const override;
>         bool SensorEmbeddedDataPresent() const override;
>
>  private:
> @@ -62,6 +63,12 @@ double CamHelperImx477::Gain(uint32_t gain_code) const
>         return 1024.0 / (1024 - gain_code);
>  }
>
> +void CamHelperImx477::GetDelays(int &exposure_delay, int &gain_delay) const
> +{
> +       exposure_delay = 2;
> +       gain_delay = 2;
> +}
> +
>  bool CamHelperImx477::SensorEmbeddedDataPresent() const
>  {
>         return true;
> --
> 2.25.1
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel