[libcamera-devel] [PATCH] meson: ipa, proxy: Only build proxies for enabled pipelines

[Kieran Bingham]

On 18/02/2021 13:35, Jacopo Mondi wrote:
> Hi Niklas,
> 
> On Wed, Feb 17, 2021 at 11:03:58AM +0100, Niklas Söderlund wrote:
>> All the IPA proxies are build unconditionally consuming unneeded build
>> time and disk space on target. Fix this by only building the proxies for
>> the enabled pipelines.
>>
>> Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
> 
> Makes sense!
> Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

Likewise,

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> 
> Thanks
>   j
> 
>> ---
>>  include/libcamera/ipa/meson.build | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/include/libcamera/ipa/meson.build b/include/libcamera/ipa/meson.build
>> index fe8aa65b7d0bfd6d..a4d3f868dd41276f 100644
>> --- a/include/libcamera/ipa/meson.build
>> +++ b/include/libcamera/ipa/meson.build
>> @@ -72,6 +72,10 @@ ipa_mojoms = []
>>  foreach file : ipa_mojom_files
>>      name = file.split('.')[0]
>>
>> +    if not get_option('pipelines').contains(name)
>> +        continue
>> +    endif
>> +
>>      # {pipeline}.mojom-module
>>      mojom = custom_target(file.split('.')[0] + '_mojom_module',
>>                            input : file,
>> --
>> 2.30.1
>>
>> _______________________________________________
>> libcamera-devel mailing list
>> libcamera-devel at lists.libcamera.org
>> https://lists.libcamera.org/listinfo/libcamera-devel
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
> 

-- 
Regards
--
Kieran