[libcamera-devel] [PATCH] libcamera: pipeline: ipu3: change IF_CROP_MAX to 40

Dave Olsthoorn dave at bewaar.me
Sat Feb 20 11:06:08 CET 2021


The value of IF_CROP_MAX seems to be a typo. A resolution of 40x540 seems
unlikely and excludes camera's with a 640x480 resolution, like the OV7251
in several Microsoft Surface products, from working.

This patch corrects the value to 40 since a minimal resolution of 40x40
seems more logical.
---
 src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp
index d5cf05b0..fb995008 100644
--- a/src/libcamera/pipeline/ipu3/imgu.cpp
+++ b/src/libcamera/pipeline/ipu3/imgu.cpp
@@ -42,7 +42,7 @@ static constexpr unsigned int BDS_ALIGN_W = 2;
 static constexpr unsigned int BDS_ALIGN_H = 4;
 
 static constexpr unsigned int IF_CROP_MAX_W = 40;
-static constexpr unsigned int IF_CROP_MAX_H = 540;
+static constexpr unsigned int IF_CROP_MAX_H = 40;
 
 static constexpr float BDS_SF_MAX = 2.5;
 static constexpr float BDS_SF_MIN = 1.0;
-- 
2.29.2



More information about the libcamera-devel mailing list