[libcamera-devel] [PATCH v2 2/2] android: camera_device: Set the camera location to Front if External

Paul Elder paul.elder at ideasonboard.com
Mon Feb 22 09:01:12 CET 2021


Our android HAL implementation currently does not support external
cameras, so if the camera location property is external, set it to
front.

This allows the following CTS test to pass:
- android.hardware.camera2.cts.CameraManagerTest#testCameraManagerGetDeviceIdList

Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

---
No change in v2
---
 src/android/camera_device.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
index 1e2a5b5f..16cb8c6d 100644
--- a/src/android/camera_device.cpp
+++ b/src/android/camera_device.cpp
@@ -405,7 +405,11 @@ int CameraDevice::initialize()
 			facing_ = CAMERA_FACING_BACK;
 			break;
 		case properties::CameraLocationExternal:
-			facing_ = CAMERA_FACING_EXTERNAL;
+			/*
+			 * \todo Set this to EXTERNAL once we support
+			 * HARDWARE_LEVEL_EXTERNAL
+			 */
+			facing_ = CAMERA_FACING_FRONT;
 			break;
 		}
 	}
-- 
2.27.0



More information about the libcamera-devel mailing list