[libcamera-devel] [PATCH] libcamera: raspberrypi: Drop std::move() where misleading

[Naushir Patuck]

Hi Laurent,

Thank you for the patch.

On Mon, 22 Feb 2021 at 10:46, Laurent Pinchart <
laurent.pinchart at ideasonboard.com> wrote:

> Usage of std::move() on a const lvalue will produce a const rvalue,
> which the compiler will bind to the const lvalue reference of the
> constructor or assignement operator. This results in the object being
> copied, not moved. Drop std::move() in that case as it's misleading.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>

Reviewed-by: Naushir Patuck <naush at raspberrypi.com>


> ---
>  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> index 5bab313b5cc7..46b7c6dbba0a 100644
> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> @@ -1289,7 +1289,7 @@ void RPiCameraData::statsMetadataComplete(uint32_t
> bufferId, const ControlList &
>
>         /* Fill the Request metadata buffer with what the IPA has provided
> */
>         Request *request = requestQueue_.front();
> -       request->metadata() = std::move(controls);
> +       request->metadata() = controls;
>
>         /*
>          * Also update the ScalerCrop in the metadata with what we actually
> @@ -1338,7 +1338,7 @@ void RPiCameraData::embeddedComplete(uint32_t
> bufferId)
>
>  void RPiCameraData::setIspControls(const ControlList &controls)
>  {
> -       ControlList ctrls = std::move(controls);
> +       ControlList ctrls = controls;
>
>         if (ctrls.contains(V4L2_CID_USER_BCM2835_ISP_LENS_SHADING)) {
>                 ControlValue &value =
> --
> Regards,
>
> Laurent Pinchart
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20210222/6885deaf/attachment.htm>