[libcamera-devel] [PATCH v2 0/3] rkisp1: add an initial support to different hw revision

Dafna Hirschfeld dafna.hirschfeld at collabora.com
Thu Feb 25 18:12:02 CET 2021


In kernel v5.11 the rkisp1 uapi had changed to support
different hardware versions. See [1]
This patchsets updates the uapi header and adds support
to hardware version 10 only.
In the future we want to add support to version V12.
See revisions documentation at [2].

The patchset is based on v8 of the 3 IPA isolation patchsets.

[1] https://patchwork.kernel.org/project/linux-media/list/?series=419197

[2] https://www.kernel.org/doc/html/latest/admin-guide/media/rkisp1.html?highlight=revisions#revisions

Changes from v1:
- compilation fix in patch 3 that I forgot to update in first version
- typo fixes
- in patch 2, if 'configure' of the rkisp1 IPA fails return -EINVAL
- in patch 3, if hw revision is not supported, return -ENODEV

Dafna Hirschfeld (3):
  libcamera: media_device: add hwRevision method
  src: rkisp1: return error from ipa's configure method if it fails
  ipa: rkisp1: update the uapi to the latest kernel version

 include/libcamera/internal/media_device.h |  2 +
 include/libcamera/ipa/rkisp1.mojom        |  4 +-
 include/linux/rkisp1-config.h             | 88 ++++++++++++++++++++---
 src/ipa/rkisp1/rkisp1.cpp                 | 23 ++++--
 src/libcamera/media_device.cpp            |  1 +
 src/libcamera/pipeline/rkisp1/rkisp1.cpp  |  8 ++-
 6 files changed, 104 insertions(+), 22 deletions(-)

-- 
2.17.1



More information about the libcamera-devel mailing list