[libcamera-devel] [PATCH v4 0/6] libcamera: camera_sensor: Make validation more strict

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon Jan 4 14:11:16 CET 2021


Hi Jacopo,

On Thu, Dec 31, 2020 at 12:05:57AM +0100, Jacopo Mondi wrote:
> It is my understanding that this series could be pushed if the UVC pipeline
> handler is instrumented to report properties that cannot be read from the
> kernel interface.

That should be a matter of adding the two pixel array properties, based
on the largest resolution reported by the device. It should hopefully be
fairly simple. Could you add such a patch to the series ?

> Jacopo Mondi (6):
>   libcamera: Document sensor driver requirements
>   libcamera: camera_sensor: Validate driver support
>   libcamera: camera_sensor: Cache selection targets
>   libcamera: camera_sensor: Default 'location' to External
>   libcamera: camera_sensor: Do not default 'rotation'
>   android: camera_device: Do not default pixel array properties
> 
>  Documentation/index.rst                      |   1 +
>  Documentation/meson.build                    |   1 +
>  Documentation/sensor_driver_requirements.rst |  64 ++++++++
>  include/libcamera/internal/camera_sensor.h   |   4 +
>  src/android/camera_device.cpp                |  20 +--
>  src/libcamera/camera_sensor.cpp              | 158 +++++++++++++------
>  6 files changed, 186 insertions(+), 62 deletions(-)
>  create mode 100644 Documentation/sensor_driver_requirements.rst

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list