[libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Stop ImgU and CIO2 on IPA error path

Umang Jain email at uajain.com
Fri Jan 8 19:01:13 CET 2021


Do not let freeBuffers() run before ImgU and CIO2 are stopped on IPA
configuration failure path.

Signed-off-by: Umang Jain <email at uajain.com>
Suggested-by: Jacopo Mondi <jacopo at jmondi.org>
Change-Id: Iadf0c950c24dcd3b6788275e36f2c028fbc53d7b
---
 src/libcamera/pipeline/ipu3/ipu3.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
index 6cd1879a..3c7f98a9 100644
--- a/src/libcamera/pipeline/ipu3/ipu3.cpp
+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
@@ -694,6 +694,8 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] ControlList *con
 	if ((result.operation != IPU3_IPA_STATUS_CONFIGURATION) ||
 	    (result.data.size() != 1) || (result.data.at(0) != 1)) {
 		LOG(IPU3, Warning) << "Failed to configure IPA";
+		imgu->stop();
+		cio2->stop();
 		ret = -EINVAL;
 		goto error;
 	}
-- 
2.29.2



More information about the libcamera-devel mailing list