[libcamera-devel] [PATCH 3/6] android: jpeg: exif: Fix setOrientation EXIF values

Paul Elder paul.elder at ideasonboard.com
Thu Jan 14 11:40:32 CET 2021


The input to setOrientation is angle clockwise from 12 o'clock, while
the EXIF output values were swapped for 90 and 270 degrees.

>From the EXIF spec:

6 = The 0th row is the visual right-hand side of the image, and the
    0th column is the visual top.
8 = The 0th row is the visual left-hand side of the image, and the
    0th column is the visual bottom.

6 should be 90 degrees clockwise, while 8 should 270 degrees clockwise.
Fix this.

Sogned-off-by: Paul Elder <paul.elder at ideasonboard.com>
---
 src/android/jpeg/exif.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/android/jpeg/exif.cpp b/src/android/jpeg/exif.cpp
index 33b3fa7f..b19cb4cd 100644
--- a/src/android/jpeg/exif.cpp
+++ b/src/android/jpeg/exif.cpp
@@ -263,13 +263,13 @@ void Exif::setOrientation(int orientation)
 		value = 1;
 		break;
 	case 90:
-		value = 8;
+		value = 6;
 		break;
 	case 180:
 		value = 3;
 		break;
 	case 270:
-		value = 6;
+		value = 8;
 		break;
 	}
 
-- 
2.27.0



More information about the libcamera-devel mailing list