[libcamera-devel] [PATCH 2/2] Documentation: sensor-driver: Correct camera rotation

Kieran Bingham kieran.bingham at ideasonboard.com
Mon Jan 18 15:34:28 CET 2021


On 18/01/2021 11:46, Jacopo Mondi wrote:
> The description of the V4L2_CID_CAMERA_SENSOR_ROTATION control
> usage wrongly mentioned the camera "orientation" while it actually
> reports the camera rotation.
> 
> Fix it by using the right term.

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> Reported-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> ---
>  Documentation/sensor_driver_requirements.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/sensor_driver_requirements.rst b/Documentation/sensor_driver_requirements.rst
> index 8cd24c15ca63..1dc8c890d16d 100644
> --- a/Documentation/sensor_driver_requirements.rst
> +++ b/Documentation/sensor_driver_requirements.rst
> @@ -43,7 +43,7 @@ The sensor driver should support the following V4L2 controls:
>  .. _V4L2_CID_CAMERA_ORIENTATION: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/ext-ctrls-camera.html
>  .. _V4L2_CID_CAMERA_SENSOR_ROTATION: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/ext-ctrls-image-process.html
>  
> -The controls are used to register the camera location and orientation.
> +The controls are used to register the camera location and rotation.
>  
>  The sensor driver should implement support for the V4L2 Selection API,
>  specifically it should implement support for the
> 

-- 
Regards
--
Kieran


More information about the libcamera-devel mailing list