[libcamera-devel] [PATCH 11/12] android: camera_device: Support AWB_AUTO

Niklas Söderlund niklas.soderlund at ragnatech.se
Mon Jan 18 16:40:59 CET 2021


Hi Jacopo,

Thanks for your work.

On 2021-01-05 20:05:21 +0100, Jacopo Mondi wrote:
> Claim support for the AWB_AUTO mode in the
> ANDROID_CONTROL_AWB_AVAILABLE_MODES static metadata.
> 
> This fixes the CTS test error:
> android.hardware.camera2.cts.CaptureRequestTest#testAwbModeAndLock fail
> The static info key 'android.control.awbAvailableModes'
> All camera devices must support AUTO mode
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

> ---
>  src/android/camera_device.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
> index 5f5e6576365b..6eb3404739e8 100644
> --- a/src/android/camera_device.cpp
> +++ b/src/android/camera_device.cpp
> @@ -802,7 +802,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()
>  				  availableStabilizationModes.size());
>  
>  	std::vector<uint8_t> availableAwbModes = {
> -		ANDROID_CONTROL_AWB_MODE_OFF,
> +		ANDROID_CONTROL_AWB_MODE_AUTO,
>  	};
>  	staticMetadata_->addEntry(ANDROID_CONTROL_AWB_AVAILABLE_MODES,
>  				  availableAwbModes.data(),
> -- 
> 2.29.2
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

-- 
Regards,
Niklas Söderlund


More information about the libcamera-devel mailing list