[libcamera-devel] Fork libyuv in libcamera codebase

[Kieran Bingham]

Hi Hiro,

On 19/01/2021 05:59, Hirokazu Honda wrote:
> On Tue, Jan 19, 2021 at 2:42 PM Laurent Pinchart
> <laurent.pinchart at ideasonboard.com> wrote:
>>
>> Hi Hiro,
>>
>> On Tue, Jan 19, 2021 at 11:06:45AM +0900, Hirokazu Honda wrote:
>>> Hi,
>>>
>>> Per the discussion in [1], we would fork libyuv in libcamera codebase
>>> for general image processing.
>>> A question is how to add the directory in libcamera.
>>> If a patch is sent, the patch is quite large.
>>> I think we would rather send a pull request or tree owners just check in it?
>>
>> A patch that imports the libyuv sources in libcamera would indeed be
>> very large. Would it be possible to use a meson subproject ?
>>
> 
> That sounds good to me.
> Let me try.

Look at how meson handles 'wraps' in particular.

https://mesonbuild.com/Wrap-dependency-system-manual.html

It should (I think) be possible to reference the libyuv project
separately, but libyuv might have to have a meson build system (which
you could add upstream I expect).

It looks like you can also provide the meson integration as a separate
'patch' on top within the wrap too, which also means we don't have to
keep a fork of libyuv as part of libcamera.

--
Kieran




> Best Regards,
> -Hiro
> 
>>> [1] https://lists.libcamera.org/pipermail/libcamera-devel/2020-December/015705.html
>>
>> --
>> Regards,
>>
>> Laurent Pinchart
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
> 

-- 
Regards
--
Kieran