[libcamera-devel] [PATCH] libcamera: Use meson summary() function to summarize configuration

[Sebastian Fricke]

On 20.01.2021 13:38, Laurent Pinchart wrote:
>Hi Sebastian,
>
>On Wed, Jan 20, 2021 at 10:11:41AM +0100, Sebastian Fricke wrote:
>> Hey Laurent,
>>
>> Thank you for the patch, it applies well and looks good.
>
>Does this imply I have your Reviewed-by tag ? :-)

Absolutly :)

Reviewed-by: Sebastian Fricke <sebastian.fricke at posteo.net>
>
>> ```
>> ...
>> Configuring config.h using configuration
>> Program python3 (jinja2, ply, jinja2, yaml) found: YES (/usr/bin/python3) modules: jinja2, ply, jinja2, yaml
>> Build targets in project: 80
>>
>> libcamera 0.0.0
>>
>>    Configuration
>>      Enabled pipelines: ipu3
>>                         raspberrypi
>>                         rkisp1
>>                         simple
>>                         uvcvideo
>>                         vimc
>>
>> Found ninja-1.10.1 at /usr/bin/ninja
>> ...
>> ```
>>
>> Greetings,
>> Sebastian
>>
>> On 20.01.2021 09:40, Laurent Pinchart wrote:
>> > Now that Debian backports have been updated to meson v0.56, all major
>> > distributions provide meson >= v0.53 in their latest LTS version. We can
>> > replace the manual message()-based configuration summary with the
>> > summmary() function.
>> >
>> > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>> > ---
>> >  meson.build | 6 ++++--
>> >  1 file changed, 4 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/meson.build b/meson.build
>> > index c47eb420f4db..743cb1d299f7 100644
>> > --- a/meson.build
>> > +++ b/meson.build
>> > @@ -1,7 +1,7 @@
>> >  # SPDX-License-Identifier: CC0-1.0
>> >
>> >  project('libcamera', 'c', 'cpp',
>> > -    meson_version : '>= 0.51',
>> > +    meson_version : '>= 0.53',
>> >      version : '0.0.0',
>> >      default_options : [
>> >          'werror=true',
>> > @@ -155,4 +155,6 @@ py_mod = import('python')
>> >  py_mod.find_installation('python3', modules: py_modules)
>> >
>> >  ## Summarise Configurations
>> > -message('Enabled pipelines: ' + ', '.join(get_option('pipelines')))
>> > +summary({
>> > +            'Enabled pipelines': get_option('pipelines'),
>> > +        }, section : 'Configuration')
>
>-- 
>Regards,
>
>Laurent Pinchart