[libcamera-devel] [PATCH] libcamera: Use meson summary() function to summarize configuration

Kieran Bingham kieran.bingham at ideasonboard.com
Wed Jan 20 16:17:22 CET 2021


Hi Laurent,

On 20/01/2021 07:40, Laurent Pinchart wrote:
> Now that Debian backports have been updated to meson v0.56, all major
> distributions provide meson >= v0.53 in their latest LTS version. We can
> replace the manual message()-based configuration summary with the
> summmary() function.

s/summmary/summary/

Great - this will help reporting things in a cleaner fashion moving
forwards.

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  meson.build | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index c47eb420f4db..743cb1d299f7 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: CC0-1.0
>  
>  project('libcamera', 'c', 'cpp',
> -    meson_version : '>= 0.51',
> +    meson_version : '>= 0.53',
>      version : '0.0.0',
>      default_options : [
>          'werror=true',
> @@ -155,4 +155,6 @@ py_mod = import('python')
>  py_mod.find_installation('python3', modules: py_modules)
>  
>  ## Summarise Configurations
> -message('Enabled pipelines: ' + ', '.join(get_option('pipelines')))
> +summary({
> +            'Enabled pipelines': get_option('pipelines'),
> +        }, section : 'Configuration')
> 

-- 
Regards
--
Kieran


More information about the libcamera-devel mailing list