[libcamera-devel] [PATCH 1/4] raspberrypi: Add the correct integer const postfix for FrameDurations

[Naushir Patuck]

Hi Kieran,

On Thu, 21 Jan 2021, 12:42 pm Kieran Bingham, <
kieran.bingham at ideasonboard.com> wrote:

> Hi Naush,
>
> On 21/01/2021 11:58, Naushir Patuck wrote:
> > At startup, ControlInfoMap::generateIdmap() threw a log message warning
> > that the controls::FrameDurations had a type mismatch based on the
> > min/max values provided in libcamera::RPi::Controls initialiser.
> >
> > Fix this warning by adding and explicit int64_t postfix to the const
> > values for min and max.
> >
> > Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> > ---
> >  include/libcamera/ipa/raspberrypi.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/libcamera/ipa/raspberrypi.h
> b/include/libcamera/ipa/raspberrypi.h
> > index 1de36039cee0..8e704d922ce6 100644
> > --- a/include/libcamera/ipa/raspberrypi.h
> > +++ b/include/libcamera/ipa/raspberrypi.h
> > @@ -65,7 +65,7 @@ static const ControlInfoMap Controls = {
> >       { &controls::Sharpness, ControlInfo(0.0f, 16.0f, 1.0f) },
> >       { &controls::ColourCorrectionMatrix, ControlInfo(-16.0f, 16.0f) },
> >       { &controls::ScalerCrop, ControlInfo(Rectangle{}, Rectangle(65535,
> 65535, 65535, 65535), Rectangle{}) },
> > -     { &controls::FrameDurations, ControlInfo(1000, 1000000000) },
> > +     { &controls::FrameDurations, ControlInfo(INT64_C(1000),
> INT64_C(1000000000)) },
>
> Is this casting a boost-ism?
>

I thought it was part of stdint, but admittedly never checked to confirm.
Will do so in a bit.

Regards,
Naush


>
>
> >  };
> >
> >  } /* namespace RPi */
> >
>
> --
> Regards
> --
> Kieran
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20210121/a1975af8/attachment.htm>