[libcamera-devel] [PATCH 7/7] android: camera_metadata: Remove outdated comment

[Laurent Pinchart]

Hi Jacopo,

Thank you for the patch.

On Thu, Jan 21, 2021 at 05:53:05PM +0100, Jacopo Mondi wrote:
> The comment was moot, as the translation of Android's settings
> to libcamera controls is already implemented in a dedicated function.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Very nice cleanup overall, it's much nicer to read.

> ---
>  src/android/camera_device.cpp | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
> index d185fdf7fb2f..f9af038412b1 100644
> --- a/src/android/camera_device.cpp
> +++ b/src/android/camera_device.cpp
> @@ -1629,12 +1629,7 @@ int CameraDevice::processControls(Camera3RequestDescriptor *descriptor)
>  	if (!settings.isValid())
>  		return 0;
>  
> -	/*
> -	 * Translate the Android controls to libcamera.
> -	 *
> -	 * \todo As soon as more controls are handled, this part should be
> -	 * broken out to a dedicated function.
> -	 */
> +	/* Translate the Android request settings to libcamera controls. */
>  	camera_metadata_ro_entry_t entry;
>  	bool found = settings.getEntry(ANDROID_SCALER_CROP_REGION, &entry);
>  	if (found) {

-- 
Regards,

Laurent Pinchart