[libcamera-devel] [PATCH 0/5] Remove Raspberry Pi logging

David Plowman david.plowman at raspberrypi.com
Fri Jan 22 11:22:06 CET 2021


Hi everyone

This patch set removes the old Raspberry Pi logging from all our
control algorithms and replaces it with libcamera logging. There is
literally nothing in this patch set except for the necessary macro
replacements and a few whitespace adjustments to keep the style
checker happy.

This is actually quite an important change because, now that we're
about to publish libcamera versions of our legacy applications, it
makes it much easier to get debug information from our customers.

Perhaps the biggest question is whether to squish all the patches
together? I've not done this yet as it's easier to squish than to
un-squish, though I did roll up all the "minor" algorithms into a
single commit. But I'll happily do that if it's tidier!

Thanks and best regards
David

David Plowman (5):
  ipa: raspberrypi: controller: Replace Raspberry Pi debug with
    libcamera debug
  ipa: raspberrypi: alsc: Replace Raspberry Pi debug with libcamera
    debug
  ipa: raspberrypi: awb: Replace Raspberry Pi debug with libcamera debug
  ipa: raspberrypi: Replace Raspberry Pi debug with libcamera debug
  ipa: raspberrypi: Remove legacy Rasberry Pi logging

 src/ipa/raspberrypi/controller/algorithm.hpp  |  1 -
 src/ipa/raspberrypi/controller/controller.cpp | 29 +++---
 src/ipa/raspberrypi/controller/logging.hpp    | 30 ------
 src/ipa/raspberrypi/controller/rpi/alsc.cpp   | 59 ++++++------
 src/ipa/raspberrypi/controller/rpi/awb.cpp    | 92 ++++++++++---------
 .../controller/rpi/black_level.cpp            |  8 +-
 src/ipa/raspberrypi/controller/rpi/ccm.cpp    | 24 +++--
 .../raspberrypi/controller/rpi/contrast.cpp   | 15 ++-
 src/ipa/raspberrypi/controller/rpi/dpc.cpp    |  8 +-
 src/ipa/raspberrypi/controller/rpi/geq.cpp    | 18 ++--
 src/ipa/raspberrypi/controller/rpi/lux.cpp    | 12 ++-
 src/ipa/raspberrypi/controller/rpi/noise.cpp  | 14 ++-
 src/ipa/raspberrypi/controller/rpi/sdn.cpp    | 21 +++--
 .../raspberrypi/controller/rpi/sharpen.cpp    |  8 +-
 14 files changed, 179 insertions(+), 160 deletions(-)
 delete mode 100644 src/ipa/raspberrypi/controller/logging.hpp

-- 
2.20.1



More information about the libcamera-devel mailing list